ankitsultana opened a new issue, #11368: URL: https://github.com/apache/pinot/issues/11368
While playing with some Pinot data, I realized that Pinot in some instances doesn't do fsync and instead relies on `close(int fd)` calls (via `FileChannel#close`). One example is here: https://github.com/apache/pinot/blob/master/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/json/BaseJsonIndexCreator.java#L147 [Close doesn't flush data to disk](https://man7.org/linux/man-pages/man2/close.2.html#:~:text=Typically%2C%20filesystems%20do%20not%20flush,%2C%20use%20fsync) and one has to manually call `FileChannel#force` to make it happen (afaik). In my case, I discovered this while playing with custom code on local where I was mimicking file reads/writes similar to how Pinot does it (by using FileChannel in try-resources) and found that the file wasn't getting written to. I have just started playing with index related code so I might be missing something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
