This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 4c307e1bb2 Fix the flaky SimpleMinionClusterIntegrationTest (#11357)
4c307e1bb2 is described below
commit 4c307e1bb2a5d2ca31cb2bd041c6608eb692c640
Author: Xiaotian (Jackie) Jiang <[email protected]>
AuthorDate: Wed Aug 16 09:13:08 2023 -0700
Fix the flaky SimpleMinionClusterIntegrationTest (#11357)
---
.../integration/tests/SimpleMinionClusterIntegrationTest.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/SimpleMinionClusterIntegrationTest.java
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/SimpleMinionClusterIntegrationTest.java
index 5fab6ff72f..766fdaabf3 100644
---
a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/SimpleMinionClusterIntegrationTest.java
+++
b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/SimpleMinionClusterIntegrationTest.java
@@ -165,11 +165,11 @@ public class SimpleMinionClusterIntegrationTest extends
ClusterTest {
return false;
}
}
- assertTrue(TASK_START_NOTIFIED.get());
assertFalse(TASK_SUCCESS_NOTIFIED.get());
assertFalse(TASK_CANCELLED_NOTIFIED.get());
assertFalse(TASK_ERROR_NOTIFIED.get());
- return true;
+ // Task start callback is triggered shortly after the task start
execution asynchronously
+ return TASK_START_NOTIFIED.get();
}, STATE_TRANSITION_TIMEOUT_MS, "Failed to get all tasks IN_PROGRESS");
// Wait at most 30 seconds for ZK callback to update the controller gauges
@@ -199,9 +199,9 @@ public class SimpleMinionClusterIntegrationTest extends
ClusterTest {
}
assertTrue(TASK_START_NOTIFIED.get());
assertFalse(TASK_SUCCESS_NOTIFIED.get());
- assertTrue(TASK_CANCELLED_NOTIFIED.get());
assertFalse(TASK_ERROR_NOTIFIED.get());
- return true;
+ // Task cancelled callback is triggered shortly after the task framework
cancels the task asynchronously
+ return TASK_CANCELLED_NOTIFIED.get();
}, STATE_TRANSITION_TIMEOUT_MS, "Failed to get all tasks STOPPED");
// Wait at most 30 seconds for ZK callback to update the controller gauges
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
