Jackie-Jiang commented on code in PR #11358:
URL: https://github.com/apache/pinot/pull/11358#discussion_r1295542616
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/TableDataManager.java:
##########
@@ -56,6 +56,11 @@ void init(TableDataManagerConfig tableDataManagerConfig,
String instanceId,
*/
void start();
+ /**
+ * Stops the table data manager. Should be called only once before shutting
down the table data manager.
Review Comment:
Let's add more explanation on the difference between `stop()` and
`shutDown()`. Currently the contract around `stop()` is not very clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
