Jackie-Jiang commented on code in PR #11355:
URL: https://github.com/apache/pinot/pull/11355#discussion_r1295404392
##########
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarMessageBatch.java:
##########
@@ -49,11 +49,16 @@ public int getMessageCount() {
return _messageList.size();
}
+ @Deprecated
@Override
public PulsarStreamMessage getMessageAtIndex(int index) {
return _messageList.get(index);
}
+ @Override
+ public byte[] getMessageBytesAtIndex(int index) {
+ return getMessageAtIndex(index).getValue();
Review Comment:
(minor) Let's not use the deprecated method
```suggestion
return _messageList.get(index).getValue();
```
##########
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarMessageBatch.java:
##########
@@ -49,11 +49,16 @@ public int getMessageCount() {
return _messageList.size();
}
+ @Deprecated
@Override
public PulsarStreamMessage getMessageAtIndex(int index) {
return _messageList.get(index);
}
+ @Override
+ public byte[] getMessageBytesAtIndex(int index) {
+ return getMessageAtIndex(index).getValue();
+ }
Review Comment:
(minor) Add an empty line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
