This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 2c4b3ff1f2 Add meter for broker responses with unavailable segments
(#11301)
2c4b3ff1f2 is described below
commit 2c4b3ff1f288e0c69f08ba303f319ee92f5a966d
Author: Xiaotian (Jackie) Jiang <[email protected]>
AuthorDate: Tue Aug 8 23:07:12 2023 -0700
Add meter for broker responses with unavailable segments (#11301)
---
.../apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java | 1 +
.../src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java | 2 ++
2 files changed, 3 insertions(+)
diff --git
a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
index 0dcbdd7554..354cdf0ee2 100644
---
a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
+++
b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
@@ -615,6 +615,7 @@ public abstract class BaseBrokerRequestHandler implements
BrokerRequestHandler {
errorMessage = String.format("%d segments unavailable: %s",
numUnavailableSegments, unavailableSegments);
}
exceptions.add(QueryException.getException(QueryException.BROKER_SEGMENT_UNAVAILABLE_ERROR,
errorMessage));
+ _brokerMetrics.addMeteredTableValue(rawTableName,
BrokerMeter.BROKER_RESPONSES_WITH_UNAVAILABLE_SEGMENTS, 1);
}
if (offlineBrokerRequest == null && realtimeBrokerRequest == null) {
diff --git
a/pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java
b/pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java
index 606eeb05a6..7854e80806 100644
---
a/pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java
+++
b/pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java
@@ -62,6 +62,8 @@ public enum BrokerMeter implements AbstractMetrics.Meter {
// This metric track the number of broker responses with processing
exceptions inside.
// The processing exceptions could be caught from both server side and
broker side.
BROKER_RESPONSES_WITH_PROCESSING_EXCEPTIONS("badResponses", false),
+ // This metric tracks the number of broker responses with unavailable
segments.
+ BROKER_RESPONSES_WITH_UNAVAILABLE_SEGMENTS("badResponses", false),
// This metric track the number of broker responses with not all servers
responded.
// (numServersQueried > numServersResponded)
BROKER_RESPONSES_WITH_PARTIAL_SERVERS_RESPONDED("badResponses", false),
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
