gortiz commented on code in PR #11205:
URL: https://github.com/apache/pinot/pull/11205#discussion_r1286919699
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##########
@@ -81,9 +84,10 @@ public void cancel(Throwable t) {
_contentObserver = getContentObserver();
}
try {
+ String msg = t != null ? t.getMessage() : "Unknown";
Review Comment:
Id doesn't hurt. I think it is a small cost with the huge benefit of not
having to see NPEs in the logs while trying to find what was the actual reason
to cancel the op chain :laughing:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
