walterddr commented on code in PR #11201:
URL: https://github.com/apache/pinot/pull/11201#discussion_r1276938999
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/BaseMailboxReceiveOperator.java:
##########
@@ -59,13 +59,15 @@ public BaseMailboxReceiveOperator(OpChainExecutionContext
context, RelDistributi
int workerId = context.getServer().workerId();
MailboxMetadata senderMailBoxMetadatas =
context.getStageMetadata().getWorkerMetadataList().get(workerId).getMailBoxInfosMap().get(senderStageId);
- Preconditions.checkState(senderMailBoxMetadatas != null &&
!senderMailBoxMetadatas.getMailBoxIdList().isEmpty(),
- "Failed to find mailbox for stage: %s",
- senderStageId);
- _mailboxIds = MailboxIdUtils.toMailboxIds(requestId,
senderMailBoxMetadatas);
- _mailboxes = _mailboxIds.stream()
- .map(mailboxId -> _mailboxService.getReceivingMailbox(mailboxId))
- .collect(Collectors.toCollection(ArrayDeque::new));
+ if (senderMailBoxMetadatas != null &&
!senderMailBoxMetadatas.getMailBoxIdList().isEmpty()) {
Review Comment:
discussed offline. this should be allowed. instead we should make a empty
server check on WorkerManager to ensure that no empty server plan for
intermediate stage is allowed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
