This is an automated email from the ASF dual-hosted git repository.
sajjad pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 85bfeb4e17 Allow setting the default MergeRollupTask segment group
manager (#11101)
85bfeb4e17 is described below
commit 85bfeb4e17383d3552fc4beb623a3c3f9daec1e3
Author: Jiapeng Tao <[email protected]>
AuthorDate: Fri Jul 14 17:42:04 2023 -0700
Allow setting the default MergeRollupTask segment group manager (#11101)
---
...MergeRollupTaskSegmentGroupManagerProvider.java | 23 +++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git
a/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/segmentgroupmananger/MergeRollupTaskSegmentGroupManagerProvider.java
b/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/segmentgroupmananger/MergeRollupTaskSegmentGroupManagerProvider.java
index ca163f20f2..3f3defb44c 100644
---
a/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/segmentgroupmananger/MergeRollupTaskSegmentGroupManagerProvider.java
+++
b/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/segmentgroupmananger/MergeRollupTaskSegmentGroupManagerProvider.java
@@ -27,20 +27,25 @@ import org.apache.pinot.spi.plugin.PluginManager;
* Provider class for {@link MergeRollupTaskSegmentGroupManager}
*/
public abstract class MergeRollupTaskSegmentGroupManagerProvider {
+
+ private static String _defaultMergeRollupTaskSegmentGroupManagerClassName =
+ DefaultMergeRollupTaskSegmentGroupManager.class.getName();
+
+ public static void
setDefaultMergeRollupTaskSegmentGroupManagerClassName(String className) {
+ _defaultMergeRollupTaskSegmentGroupManagerClassName = className;
+ }
+
/**
* Constructs the {@link MergeRollupTaskSegmentGroupManager} using
MergeRollup task configs
*/
public static MergeRollupTaskSegmentGroupManager create(Map<String, String>
taskConfigs) {
String segmentGroupManagerClassName =
-
taskConfigs.get(MinionConstants.MergeRollupTask.SEGMENT_GROUP_MANAGER_CLASS_NAME_KEY);
- if (segmentGroupManagerClassName != null) {
- try {
- return
PluginManager.get().createInstance(segmentGroupManagerClassName);
- } catch (Exception e) {
- throw new RuntimeException("Fail to create segment group manager", e);
- }
- } else {
- return new DefaultMergeRollupTaskSegmentGroupManager();
+
taskConfigs.getOrDefault(MinionConstants.MergeRollupTask.SEGMENT_GROUP_MANAGER_CLASS_NAME_KEY,
+ _defaultMergeRollupTaskSegmentGroupManagerClassName);
+ try {
+ return PluginManager.get().createInstance(segmentGroupManagerClassName);
+ } catch (Exception e) {
+ throw new RuntimeException("Fail to create segment group manager", e);
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
