gortiz opened a new pull request, #11112:
URL: https://github.com/apache/pinot/pull/11112

   This PR applies some easy win optimizations trying to reduce the Object[] 
allocation in V2. Results are not as good as expected, given that they mostly 
attack incorrect ArrayList initializations while the actual improvement will be 
trying to reduce how many ArrayList are created. The latter is something I 
would like to achieve, but the changes required are not as simple as the ones 
included here.
   
   Allocations pre change:
   
![image](https://github.com/apache/pinot/assets/1913993/22e34578-5ebc-4966-a3e5-55cfca06fc65)
   
   Allocations post change:
   
![image](https://github.com/apache/pinot/assets/1913993/d2b61c4e-ff19-45aa-8dcd-a3eb6f2e94ea)
   
   Notice that:
   * The improvement is mainly in the gray areas
   * Flamegraphs show a relative performance
   * The difference in outside TLAB allocation
   * Charts were generated after running queries for 5 mins, but I've only made 
one execution per case, so I'm not sure about repeatability 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to