walterddr commented on code in PR #11097:
URL: https://github.com/apache/pinot/pull/11097#discussion_r1263760742
##########
pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java:
##########
@@ -98,9 +100,25 @@ public enum TransformFunctionType {
OperandTypes.family(ImmutableList.of(SqlTypeFamily.ANY,
SqlTypeFamily.CHARACTER)), "json_extract_key"),
// date time functions
- TIMECONVERT("timeConvert", "time_convert"),
- DATETIMECONVERT("dateTimeConvert", "date_time_convert"),
- DATETRUNC("dateTrunc", "datetrunc"),
+ TIMECONVERT("timeConvert",
+ ReturnTypes.BIGINT_FORCE_NULLABLE,
+ OperandTypes.family(ImmutableList.of(SqlTypeFamily.ANY,
SqlTypeFamily.CHARACTER, SqlTypeFamily.CHARACTER)),
+ "time_convert"),
+
+ DATETIMECONVERT("dateTimeConvert",
+ ReturnTypes.cascade(
+ opBinding -> dateTimeConverterReturnTypeInference(opBinding),
+ SqlTypeTransforms.FORCE_NULLABLE),
Review Comment:
this one is not force nulllable. dateTime convert is only null when input is
null (unlike json extract)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
