chenboat commented on code in PR #10752:
URL: https://github.com/apache/pinot/pull/10752#discussion_r1195840785
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1404,6 +1405,8 @@ public void uploadToDeepStoreIfMissing(TableConfig
tableConfig, List<SegmentZKMe
retentionMs -
MIN_TIME_BEFORE_SEGMENT_EXPIRATION_FOR_FIXING_DEEP_STORE_COPY_MILLIS);
}
+ PinotFS pinotFS = createPinotFS(rawTableName);
Review Comment:
PinotFS is not per table but per Pinot cluster. It is a bit strange to
create the PinotFS from a table name. After looking through the two private
methods added, it is much more clearer if we can get the PinotFS based on the
scheme part of _controllerConf.getDataDir().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
