abhioncbr commented on code in PR #10765:
URL: https://github.com/apache/pinot/pull/10765#discussion_r1194103588


##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTestBase.java:
##########
@@ -156,7 +157,11 @@ protected List<Object[]> queryH2(String sql)
     while (h2ResultSet.next()) {
       Object[] row = new Object[columnCount];
       for (int i = 0; i < columnCount; i++) {
-        row[i] = h2ResultSet.getObject(i + 1);
+        if (h2ResultSet.getMetaData().getColumnType(i + 1) == Types.OTHER) {
+          row[i] = h2ResultSet.getString(i + 1);

Review Comment:
   H2 has the [json 
support](https://www.h2database.com/html/datatypes.html#json_type), but we can 
not test transformation functions with H2. I'll use your suggested one. Thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to