gortiz commented on code in PR #10757:
URL: https://github.com/apache/pinot/pull/10757#discussion_r1191022079
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/NullValueIndexTest.java:
##########
@@ -37,13 +35,7 @@ public void oldToNewConfConversion() {
_tableConfig.getIndexingConfig().setNullHandlingEnabled(true);
convertToUpdatedFormat();
assertNotNull(_tableConfig.getFieldConfigList());
Review Comment:
This shouldn't be a requirement of the test. Whether the fieldConfigList is
null or not is not relevant for null vector type, given it does nothing.
What I would check is that getIndexingConfig().isNullHandlingEnabled is
still true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
