snleee commented on code in PR #10731:
URL: https://github.com/apache/pinot/pull/10731#discussion_r1187974822
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/segmentgenerationandpush/SegmentGenerationAndPushTaskExecutor.java:
##########
@@ -287,6 +287,9 @@ protected SegmentGenerationTaskSpec
generateTaskSpec(Map<String, String> taskCon
recordReaderSpec.setDataFormat(taskConfigs.get(BatchConfigProperties.INPUT_FORMAT));
recordReaderSpec.setClassName(taskConfigs.get(BatchConfigProperties.RECORD_READER_CLASS));
recordReaderSpec.setConfigClassName(taskConfigs.get(BatchConfigProperties.RECORD_READER_CONFIG_CLASS));
+ recordReaderSpec.setConfigs(
Review Comment:
Have we set up the code style? If not, let's set up the pinot style in IDE
and apply the code style change.
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/test/java/org/apache/pinot/plugin/minion/tasks/segmentgenerationandpush/SegmentGenerationAndPushTaskGeneratorTest.java:
##########
@@ -78,4 +86,52 @@ public void testRealCluster()
ControllerTest.sendPostRequest(_controllerRequestURLBuilder.forClusterConfigs(),
request);
Assert.assertEquals(_generator.getNumConcurrentTasksPerInstance(), 1);
}
+
+ @Test
+ public void testGenerateTaskSpec() throws Exception {
+ URL resourcesLoc =
SegmentGenerationAndPushTaskGeneratorTest.class.getClassLoader().getResource(".");
+ SegmentGenerationAndPushTaskExecutor executor = new
SegmentGenerationAndPushTaskExecutor();
+ Schema schema = new Schema.SchemaBuilder().build();
+ // FieldUtils.writeField(executor, "_pinotTaskConfig", new
PinotTaskConfig("",
Review Comment:
(nit) Can we remove this line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
