saurabhd336 commented on code in PR #10687:
URL: https://github.com/apache/pinot/pull/10687#discussion_r1180298384
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/inverted/InvertedIndexType.java:
##########
@@ -193,4 +196,16 @@ public InvertedIndexReader
createSkippingForward(SegmentDirectory.Reader segment
protected void handleIndexSpecificCleanup(TableConfig tableConfig) {
tableConfig.getIndexingConfig().setInvertedIndexColumns(null);
}
+
+ @Nullable
+ @Override
+ public MutableIndex createMutableIndex(MutableIndexContext context,
IndexConfig config) {
+ if (config.isDisabled()) {
+ return null;
+ }
+ if (!context.hasDictionary()) {
+ return null;
Review Comment:
Other places too. I think a lot of the cases are table creation level
validations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
