andimiller commented on code in PR #10427: URL: https://github.com/apache/pinot/pull/10427#discussion_r1179371002
########## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/IntegerTupleSketchAggregationFunction.java: ########## @@ -0,0 +1,213 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.aggregation.function; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Base64; +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; +import org.apache.datasketches.tuple.CompactSketch; +import org.apache.datasketches.tuple.Sketch; +import org.apache.datasketches.tuple.Union; +import org.apache.datasketches.tuple.aninteger.IntegerSummary; +import org.apache.datasketches.tuple.aninteger.IntegerSummarySetOperations; +import org.apache.pinot.common.request.context.ExpressionContext; +import org.apache.pinot.common.utils.DataSchema.ColumnDataType; +import org.apache.pinot.core.common.BlockValSet; +import org.apache.pinot.core.common.ObjectSerDeUtils; +import org.apache.pinot.core.query.aggregation.AggregationResultHolder; +import org.apache.pinot.core.query.aggregation.ObjectAggregationResultHolder; +import org.apache.pinot.core.query.aggregation.groupby.GroupByResultHolder; +import org.apache.pinot.core.query.aggregation.groupby.ObjectGroupByResultHolder; +import org.apache.pinot.segment.spi.AggregationFunctionType; +import org.apache.pinot.spi.data.FieldSpec; +import org.apache.pinot.spi.utils.CommonConstants; + + +/*** + * This is the base class for all Integer Tuple Sketch aggregations + * + * Note that it only supports BYTES columns containing serialized sketches currently, but could be expanded to more + */ +public class IntegerTupleSketchAggregationFunction + extends BaseSingleInputAggregationFunction<List<CompactSketch<IntegerSummary>>, Comparable> { + final ExpressionContext _expressionContext; + final IntegerSummarySetOperations _setOps; + final int _entries; + + public IntegerTupleSketchAggregationFunction(List<ExpressionContext> arguments, IntegerSummary.Mode mode) { + super(arguments.get(0)); + _expressionContext = arguments.get(0); Review Comment: tested locally and it's doing what I expected: ```json "message": "QueryExecutionError:\nQuery execution error on: Server_172.19.14.129_7050 org.apache.pinot.spi.exception.BadQueryRequestException: Invalid aggregation function: avgvalueintegersumtuplesketch(players,'true','false'); Reason: Tuple Sketch Aggregation Function expects at most 2 arguments, got: 3" ``` ```json "message": "QueryExecutionError:\nQuery execution error on: Server_172.19.14.129_7050 org.apache.pinot.spi.exception.BadQueryRequestException: Invalid aggregation function: avgvalueintegersumtuplesketch(players,'true'); Reason: Tuple Sketch Aggregation Function expected the second argument to be a number of entries to keep, but it was of type BOOLEAN" ```` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
