gortiz commented on code in PR #10184: URL: https://github.com/apache/pinot/pull/10184#discussion_r1155760228
########## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java: ########## @@ -138,7 +138,7 @@ public class OfflineClusterIntegrationTest extends BaseClusterIntegrationTestSet private static final String COLUMN_LENGTH_MAP_KEY = "columnLengthMap"; private static final String COLUMN_CARDINALITY_MAP_KEY = "columnCardinalityMap"; private static final String MAX_NUM_MULTI_VALUES_MAP_KEY = "maxNumMultiValuesMap"; - private static final int DISK_SIZE_IN_BYTES = 20797327; Review Comment: This value can change a bit depending on the order of the indexes and stuff. @Jackie-Jiang recently changed the v1&v2 conversion in order to make it deterministic. Today we also found that there was an error in the code and inverted indexes were created even if `createInvertedIndexDuringSegmentGeneration` was false. It should be fixed in #10524. In that PR the value of this const also changes, but to be reduced to `20797324`. TBH I don't know what else may have changed the value, although the new change is just 3 bytes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
