gortiz commented on code in PR #10184:
URL: https://github.com/apache/pinot/pull/10184#discussion_r1148868990
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/converter/RealtimeSegmentConverter.java:
##########
@@ -75,9 +81,8 @@ public void build(@Nullable SegmentVersion segmentVersion,
ServerMetrics serverM
// realtime segment generation
genConfig.setSegmentTimeValueCheck(false);
if (_columnIndicesForRealtimeTable.getInvertedIndexColumns() != null) {
- for (String column :
_columnIndicesForRealtimeTable.getInvertedIndexColumns()) {
- genConfig.createInvertedIndexForColumn(column);
- }
+ genConfig.setIndexOn(InvertedIndexType.INSTANCE, IndexConfig.ENABLED,
Review Comment:
Yes, `StandardIndexes` is expected. I should modify all these singleton
instances to make them package private or move them into each `IndexPlugin` and
make them private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
