mcvsubbu commented on issue #10460: URL: https://github.com/apache/pinot/issues/10460#issuecomment-1482093713
> The `stopReason` seems to be `REASON_FORCE_COMMIT_MESSAGE_RECEIVED`, so it is identifiable. I wonder if the issue is this line, > > https://github.com/apache/pinot/blob/989df641b7d29e18773a668663b0be894835d24f/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/SegmentCompletionManager.java#L1174 > > . > The quickest fix (to this issue) would be to remove that line and let it wait for the rest of the servers. I know you mentioned we prefer to commit immediately with forceCommit, but the wait time isn't that long. `MAX_TIME_TO_PICK_WINNER_MS` seems to be hard coded to 3300ms. This is indeed the case. I am less worried about the extent of the change, than the reason why we put it there in the first place. And yes, that was the exact reason we added another value to "stopReason" -- so that the completion manager can choose to take whatever action. All logic (when I look at it now) seems to suggest that we should move back to choosing the best offset behavior for this value of stopReason. But like I said, let us think a little bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
