gortiz commented on code in PR #10192:
URL: https://github.com/apache/pinot/pull/10192#discussion_r1137271683
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/BloomFilterConfig.java:
##########
@@ -21,20 +21,27 @@
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.google.common.base.Preconditions;
-import org.apache.pinot.spi.config.BaseJsonConfig;
+import java.util.Objects;
-public class BloomFilterConfig extends BaseJsonConfig {
+public class BloomFilterConfig extends IndexConfig {
public static final double DEFAULT_FPP = 0.05;
+ private static final BloomFilterConfig DEFAULT = new
BloomFilterConfig(BloomFilterConfig.DEFAULT_FPP, 0, false);
Review Comment:
We could do that, but doesn't seem necessary. Anyway, don't study too much
the bloom related things in this PR, as most indexes are going to be added
[here](https://github.com/apache/pinot/pull/10193) and they wont be used until
https://github.com/apache/pinot/pull/10194 and specially
https://github.com/apache/pinot/pull/10184.
The reason to include bloom stuff here is to show an implementation example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
