gortiz commented on code in PR #10352:
URL: https://github.com/apache/pinot/pull/10352#discussion_r1122746290
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/SegmentGeneratorConfig.java:
##########
@@ -249,7 +250,13 @@ public SegmentGeneratorConfig(TableConfig tableConfig,
Schema schema) {
}
public Map<String, Map<String, String>> getColumnProperties() {
- return _columnProperties;
+ HashMap<String, Map<String, String>> copy = new HashMap<>();
Review Comment:
I don't think this is expensive at all. This method is called a couple of
times during the segment creation and not even in the hotpath.
Although I can change it to make them immutable at construction time if
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
