mcvsubbu commented on issue #10237: URL: https://github.com/apache/pinot/issues/10237#issuecomment-1435435011
Fair comment on the EV check. I was thinking idealstate check for OFFLINE segments (which is set by us). Bottom line: We have now defined a valid state that says that if CONSUMING segments are not present, then the idealstate should include the PAUSED bit set. This allows us to reason about the events that may have transpired easily. Another valid state is that consuming segments are present, (maybe in OFFLINE or CONSUMING state) in which case the PAUSED bit is _not_ set in the idealstate. By allowing the deletion of CONSUMING segments, we are now violating the valid states that IDEALSTATE can be in. IMO this is not a good idea. If the consuming segments are in ERROR state, and the operator issues the pause command, it should effectively delete the segment, no? We have error to offline and error to dropped state transitions iirc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
