mcvsubbu commented on a change in pull request #8047:
URL: https://github.com/apache/pinot/pull/8047#discussion_r789267079
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -1465,9 +1465,10 @@ private void makeStreamConsumer(String reason) {
if (_partitionGroupConsumer != null) {
closePartitionGroupConsumer();
}
- _segmentLogger.info("Creating new stream consumer, reason: {}", reason);
+ _segmentLogger.info("Creating new stream consumer for topic partition {} ,
reason: {}", _clientId, reason);
Review comment:
`_segmentLogger` already contains segment name (which includes
partitionGroupId). The segment name also includes the table name (which implies
the topic name). So, do you really need to add the clientId here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
