walterddr commented on a change in pull request #7911:
URL: https://github.com/apache/pinot/pull/7911#discussion_r771973799
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/ResultReducerFactory.java
##########
@@ -68,11 +67,30 @@ public static DataTableReducer
getResultReducer(QueryContext queryContext) {
}
public static StreamingReducer getStreamingReducer(QueryContext
queryContext) {
- if (!QueryContextUtils.isSelectionQuery(queryContext) ||
queryContext.getOrderByExpressions() != null) {
- throw new UnsupportedOperationException("Only selection queries are
supported");
+ AggregationFunction[] aggregationFunctions =
queryContext.getAggregationFunctions();
+ if (aggregationFunctions == null) {
+ if (queryContext.getOrderByExpressions() != null) {
+ throw new UnsupportedOperationException("Only selection queries are
supported");
Review comment:
there's select order by, gap-fill group by, and explain plan operator
that hasn't been implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]