klsince commented on a change in pull request #7737:
URL: https://github.com/apache/pinot/pull/7737#discussion_r746151693
##########
File path:
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/loader/SegmentDirectoryLoaderRegistry.java
##########
@@ -73,17 +70,27 @@ private SegmentDirectoryLoaderRegistry() {
SEGMENT_DIRECTORY_LOADER_MAP.size(),
SEGMENT_DIRECTORY_LOADER_MAP.keySet());
}
+ private SegmentDirectoryLoaderRegistry() {
+ }
+
+ /**
+ * Returns the segment directory loader instance from instantiated map, for
the given segmentDirectoryLoader name
+ */
+ public static SegmentDirectoryLoader getSegmentDirectoryLoader(String
segmentDirectoryLoader) {
+ return SEGMENT_DIRECTORY_LOADER_MAP.get(segmentDirectoryLoader);
+ }
+
/**
- * Returns the segment directory loader instance from instantiated map, for
the given tier backend
+ * Explicitly adds a {@link SegmentDirectoryLoader} to the map
*/
- public static SegmentDirectoryLoader getSegmentDirectoryLoader(String
tierBackend) {
- return SEGMENT_DIRECTORY_LOADER_MAP.get(tierBackend);
+ public static void setSegmentDirectoryLoader(String
segmentDirectoryLoaderName, SegmentDirectoryLoader loader) {
Review comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
