suddendust commented on a change in pull request #7397:
URL: https://github.com/apache/pinot/pull/7397#discussion_r720302330
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java
##########
@@ -167,10 +167,7 @@ public DataTable processQuery(ServerQueryRequest
queryRequest, ExecutorService e
// TODO: Change broker to watch both IdealState and ExternalView to not
query the removed segments
Review comment:
Removed todo.
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java
##########
@@ -251,6 +248,14 @@ public DataTable processQuery(ServerQueryRequest
queryRequest, ExecutorService e
.put(MetadataKey.MIN_CONSUMING_FRESHNESS_TIME_MS.getName(),
Long.toString(minConsumingFreshnessTimeMs));
}
+ if (numSegmentsQueried > numSegmentsAcquired) {
+ String errorMessage =
+ String.format("Some segments could not be acquired: %d",
numSegmentsQueried - numSegmentsAcquired);
Review comment:
Addressed.
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -794,6 +795,11 @@ private BrokerResponseNative handlePQLRequest(long
requestId, String query, Json
_brokerMetrics.addMeteredTableValue(rawTableName,
BrokerMeter.BROKER_RESPONSES_WITH_NUM_GROUPS_LIMIT_REACHED, 1);
}
+ if (0 != numUnavailableSegments) {
Review comment:
Addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
