klsince commented on a change in pull request #7319:
URL: https://github.com/apache/pinot/pull/7319#discussion_r708489746
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/TableDataManager.java
##########
@@ -78,6 +81,27 @@ void addSegment(File indexDir, IndexLoadingConfig
indexLoadingConfig)
void addSegment(String segmentName, TableConfig tableConfig,
IndexLoadingConfig indexLoadingConfig)
throws Exception;
+ /**
+ * Reloads an existing immutable segment for the table, which can be an
OFFLINE or REALTIME table.
+ * A new segment may be downloaded if the local one has a different CRC; or
can be forced to download
+ * if forceDownload flag is true. This operation is conducted within a
failure handling framework
+ * and made transparent to ongoing queries, because the segment is in online
serving state.
+ */
+ void reloadSegment(String segmentName, IndexLoadingConfig indexLoadingConfig,
+ SegmentZKMetadata zkMetadata, SegmentMetadata localMetadata, Schema
schema, boolean forceDownload)
Review comment:
yup, it's annotated nullable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
