jtao15 commented on issue #7413: URL: https://github.com/apache/pinot/issues/7413#issuecomment-917298621
> I think we do check the CRC when purge task pushes the segment. If that is not the case, we should add existence and CRC check We do check the crc. But the version check is still needed since in extreme cases the segment can be deleted after we check crc since the check&update is not atomic? I think we can have some sort of flag to indicate the upload request is replacement only (for purge and convertToRawIndex), if there's no existing segment or the segment got deleted before the request complete (zk version mismatch), we just abort the request. @Jackie-Jiang What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
