klsince commented on a change in pull request #7319:
URL: https://github.com/apache/pinot/pull/7319#discussion_r704605056
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
##########
@@ -248,19 +249,27 @@ public boolean isPartialUpsertEnabled() {
return _upsertMode == UpsertConfig.Mode.PARTIAL;
}
+ /**
+ * Add or replace an immutable segment created by the REALTIME table.
+ * Skipping segment still in consuming state.
+ */
+ @Override
+ public void addOrReplaceSegment(String segmentName, IndexLoadingConfig
indexLoadingConfig,
+ SegmentMetadata localMetadata, SegmentZKMetadata zkMetadata, boolean
forceDownload)
+ throws Exception {
+ throw new UnsupportedOperationException();
Review comment:
I was planning to add support for RT table in next PR, and make this one
focus on refactoring existing logic. As reload...() APIs are to be extended
with forceDownload flag, I'll double check if changes are still needed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
