mayankshriv commented on a change in pull request #7375:
URL: https://github.com/apache/pinot/pull/7375#discussion_r698626008
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/metadata/segment/SegmentZKMetadata.java
##########
@@ -409,12 +415,10 @@ public Duration getTimeGranularity() {
@Deprecated
public Interval getTimeInterval() {
- String startTimeString = _simpleFields.get(Segment.START_TIME);
- if (startTimeString != null) {
- String endTimeString = _simpleFields.get(Segment.END_TIME);
- TimeUnit timeUnit =
TimeUnit.valueOf(_simpleFields.get(Segment.TIME_UNIT));
- return new Interval(timeUnit.toMillis(Long.parseLong(startTimeString)),
- timeUnit.toMillis(Long.parseLong(endTimeString)));
+ long startTimeMs = getStartTimeMs();
Review comment:
Seems like it is deprecated, and my IDE did not find any callers. If so,
may be just remove?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
