Jackie-Jiang commented on a change in pull request #7354:
URL: https://github.com/apache/pinot/pull/7354#discussion_r694380680
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/auth/BasicAuthPrincipal.java
##########
@@ -50,6 +50,6 @@ public boolean hasTable(String tableName) {
}
public boolean hasPermission(String permission) {
- return _permissions.isEmpty() || _permissions.contains(permission);
+ return _permissions.isEmpty() || _permissions.stream().anyMatch(d ->
d.equalsIgnoreCase(permission));
Review comment:
This can be slow. Suggest fix the permissions to lower case and do
`_permissions.contains(permission.toLowerCase())`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
