mcvsubbu commented on a change in pull request #7306:
URL: https://github.com/apache/pinot/pull/7306#discussion_r689112837
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java
##########
@@ -235,7 +237,10 @@ private SuccessResponse uploadSegment(@Nullable String
tableName, TableType tabl
SegmentMetadata segmentMetadata = getSegmentMetadata(tempDecryptedFile,
tempSegmentDir, metadataProviderClass);
// Fetch segment name
- String segmentName = segmentMetadata.getName();
+ if (!StringUtils.isEmpty(segmentName)) {
Review comment:
Don't you need to replace the segment name in the metadata file and
rewrite the tar file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
