jackjlli commented on a change in pull request #7236:
URL: https://github.com/apache/pinot/pull/7236#discussion_r686156173
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java
##########
@@ -165,11 +157,13 @@ private void createOrUpdateRateLimiter(String
tableNameWithType, ExternalView br
QuotaConfig quotaConfig) {
if (quotaConfig == null || quotaConfig.getMaxQueriesPerSecond() == null) {
LOGGER.info("No qps config specified for table: {}", tableNameWithType);
+ buildEmptyOrResetRateLimiterInQueryQuotaEntity(tableNameWithType);
return;
}
if (brokerResource == null) {
LOGGER.warn("Failed to init qps quota for table {}. No broker resource
connected!", tableNameWithType);
+ buildEmptyOrResetRateLimiterInQueryQuotaEntity(tableNameWithType);
Review comment:
Even if brokerResourceEV is null for now, it can still be not null in
the future. In that case, the metrics are still needed to be appeared. Thus,
the query quota entity is still needed.
I'll update the variable name in the next push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
