snleee commented on a change in pull request #7178:
URL: https://github.com/apache/pinot/pull/7178#discussion_r684513857
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java
##########
@@ -297,10 +300,15 @@ public static void validateIngestionConfig(TableConfig
tableConfig, @Nullable Sc
}
}
- private static void validateTaskConfigs(TableConfig tableConfig) {
+ private static void validateTaskConfigs(TableConfig tableConfig, Schema
schema) {
TableTaskConfig taskConfig = tableConfig.getTaskConfig();
- if (taskConfig != null &&
taskConfig.isTaskTypeEnabled(SEGMENT_GENERATION_AND_PUSH_TASK_TYPE)) {
- Map<String, String> taskTypeConfig =
taskConfig.getConfigsForTaskType(SEGMENT_GENERATION_AND_PUSH_TASK_TYPE);
+ validateSegmentGenerationAndPushTaskConfig(taskConfig);
+ validateMergeRollupTaskConfig(taskConfig, schema);
+ }
+
+ private static void
validateSegmentGenerationAndPushTaskConfig(TableTaskConfig tableTaskConfig) {
+ if (tableTaskConfig != null &&
tableTaskConfig.isTaskTypeEnabled(SEGMENT_GENERATION_AND_PUSH_TASK_TYPE)) {
Review comment:
we can reduce the identation by
```
if (tableTaskConfig == null ||
!tableTaskConfig.isTaskTypeEnabled(SEGMENT_GENERATION_AND_PUSH_TASK_TYPE)) {
return;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
