wirybeaver commented on code in PR #19667:
URL: https://github.com/apache/pinot/pull/19667#discussion_r4116416539
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AnyValueAggregationFunction.java:
##########
@@ -309,7 +312,7 @@ private Object deserializeValue(ByteBuffer buffer) {
case BIG_DECIMAL:
return new BigDecimal(new String(deserializeVariableBytes(buffer),
StandardCharsets.UTF_8));
case BYTES:
- return deserializeVariableBytes(buffer);
+ return new ByteArray(deserializeVariableBytes(buffer));
Review Comment:
Fixed in dcf2f9f9180b5144d016980745d37f12dc6033f7. Dictionary-backed BYTES
values now use getByteArrayValue, and direct BYTES values are wrapped before
entering aggregation result holders, so both paths retain ByteArray before and
after serialization. The regression test uses actual aggregate and SV/MV
group-by results, checks final extraction and the round trip, and the obsolete
byte[] serializer branch is removed without changing the wire format.
[addressed by agent]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
