This is an automated email from the ASF dual-hosted git repository. Jackie-Jiang pushed a commit to branch fix-group-commit-empty-queue-exception in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 4194719b6930a2e7b951d460f01d6c2f80fc4bd1 Author: Xiaotian (Jackie) Jiang <[email protected]> AuthorDate: Fri Sep 25 18:02:40 2026 -0700 Propagate group commit failures when pending queue is empty --- .../org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java b/pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java index 4486c23b0cf..c0a4ab52a90 100644 --- a/pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java +++ b/pinot-common/src/main/java/org/apache/pinot/common/utils/helix/IdealStateGroupCommit.java @@ -119,8 +119,8 @@ public class IdealStateGroupCommit { ArrayList<Entry> processed = new ArrayList<>(); try { if (queue._pending.peek() == null) { - // All pending entries have been processed, the updatedIdealState should be set. - return entry._updatedIdealState; + // The entry was already processed; check its outcome below. + break; } updateIdealState(helixManager, resourceName, idealState -> { IdealState updatedIdealState = idealState; --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
