Copilot commented on code in PR #17853: URL: https://github.com/apache/pinot/pull/17853#discussion_r2926785385
########## AGENTS.md: ########## @@ -73,6 +73,7 @@ repo. It is intentionally short and focused on day-to-day work. - pinot-stream-ingestion: stream ingestion plugin family. - pinot-kafka-base: shared Kafka ingestion base classes. - pinot-kafka-3.0: Kafka 3.x ingestion implementation. + - pinot-kafka-4.0: Kafka 4.x ingestion implementation. Review Comment: The PR description/test plan says "Confirm no existing files are modified", but this PR also updates AGENTS.md. Either update the PR description/test plan to reflect the additional file change, or drop the AGENTS.md edits if the intent is to add only CLAUDE.md. ########## AGENTS.md: ########## @@ -92,7 +93,7 @@ repo. It is intentionally short and focused on day-to-day work. - assembly-descriptor: Maven assembly descriptor for plugin packaging. ## Build and test -- Build JDK: Use JDK 11+ (CI runs 11/21); code targets Java 11. +- Build JDK: Use JDK 11+ (CI runs 11/17/21); code targets Java 11. Review Comment: The Build JDK bullet says "CI runs 11/17/21", but the GitHub Actions workflows in this repo only run the main matrix on Java 11 and 21 (and several other jobs are fixed to 11). Please update this line to match the actual CI JDK versions (or reword it to distinguish 'supported' vs 'CI' if 17 is intended). ```suggestion - Build JDK: Use JDK 11+ (CI currently runs 11 and 21); code targets Java 11. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
