mluvin-stripe opened a new pull request, #17862: URL: https://github.com/apache/pinot/pull/17862
### Summary Implements https://github.com/apache/pinot/issues/17599, ensure the controller's disk utilization cache is populated before marking the controller as healthy. Otherwise, the controller may let through segment push requests even when disk usage is already 90% right after a restart, as it could take some time to populate the disk utilization cache. When `controller.resource.utilization.checker.waitDuringStartup` is enabled, i set `controller.resource.utilization.checker.initial.delay` to zero so the resource utilization checker starts running immediately. This way, controller restarts aren't delayed by waiting on the utilization checkers running with delayed start. We'll still fail open here -- if the disk utilization checker times out fetching all server's disk utilization, we'll still let the controller be marked as healthy. ### Testing Deployed this change to one of our testing Pinot clusters: 1. with `controller.resource.utilization.checker.waitDuringStartup: false` -- confirmed the controllers start normally, no waiting for the resource utilization checks to run 2. with `controller.resource.utilization.checker.waitDuringStartup: true` -- confirmed the periodic task scheduler runs the resource utilization checker immediately, and the controller doesn't get marked `GOOD` until it finishes running. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
