noob-se7en opened a new pull request, #17852:
URL: https://github.com/apache/pinot/pull/17852
**Problem**
Server and controller can disagree on the segment commit protocol. The
server decides whether to use pauseless or normal commit based on the
pauselessConsumptionEnabled flag in StreamIngestionConfig.
But the controller's createFsm() first checks for a
segment.completion.fsm.scheme override in the stream config — if someone sets
this to "pauseless" without enabling pauselessConsumptionEnabled, the
controller creates a PauselessSegmentCompletionFSM while the server does a
normal commit.
**Solution**
Remove the segment.completion.fsm.scheme stream config override from
SegmentCompletionManager.createFsm(). The controller now always derives the FSM
scheme from PauselessConsumptionUtils.isPauselessEnabled() — the same source of
truth the server uses. This eliminates any possibility of mismatch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
