xiangfu0 opened a new pull request, #17800: URL: https://github.com/apache/pinot/pull/17800
## Summary - Add global runtime switch `pinot.md5.disabled` (default `false`) via `CommonConstants` and new `PinotMd5Mode`. - Initialize `PinotMd5Mode` from node startup config in broker/controller/server/minion. - Block upsert/dedup MD5 hash function when MD5 is disabled, and add runtime fail-safe in `HashUtils.hashPrimaryKey(...)`. - Keep SQL `md5()` behavior unchanged. - In ADLS FS, make checksum effectively `enableChecksum && !PinotMd5Mode.isPinotMd5Disabled()` and warn when checksum is requested but globally disabled. - In S3 config, reject `useLegacyMd5Plugin=true` when MD5 is globally disabled. - Add/extend tests for SPI, segment-local, S3, and ADLS coverage. ## Testing - `./mvnw -pl pinot-spi -Dtest=PinotMd5ModeTest test` - `./mvnw -pl pinot-segment-local -am -Dtest=TableConfigUtilsTest,HashUtilsTest -Dsurefire.failIfNoSpecifiedTests=false -Dcheckstyle.skip=true test` - `./mvnw -pl pinot-plugins/pinot-file-system/pinot-s3 -am -Dtest=S3ConfigTest -Dsurefire.failIfNoSpecifiedTests=false -Dcheckstyle.skip=true test` - `./mvnw -pl pinot-plugins/pinot-file-system/pinot-adls -am -Dtest=ADLSGen2PinotFSTest -Dsurefire.failIfNoSpecifiedTests=false -Dcheckstyle.skip=true test` - `./mvnw -pl pinot-broker,pinot-controller,pinot-server,pinot-minion -am -DskipTests -Dcheckstyle.skip=true compile` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
