Jackie-Jiang commented on code in PR #17798:
URL: https://github.com/apache/pinot/pull/17798#discussion_r2875558524
##########
pinot-plugins/pinot-input-format/pinot-avro/src/main/java/org/apache/pinot/plugin/inputformat/avro/KafkaAvroMessageDecoder.java:
##########
@@ -60,15 +60,15 @@ public class KafkaAvroMessageDecoder implements
StreamMessageDecoder<byte[]> {
private static final String SCHEMA_REGISTRY_REST_URL =
"schema.registry.rest.url";
private static final String SCHEMA_REGISTRY_SCHEMA_NAME =
"schema.registry.schema.name";
private org.apache.avro.Schema _defaultAvroSchema;
- private MD5AvroSchemaMap _md5ToAvroSchemaMap;
+ private SchemaHashAvroSchemaMap _schemaHashToAvroSchemaMap;
Review Comment:
The name is too verbose. Suggest changing all `SchemaHash` to `Hash` for all
changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
