Jackie-Jiang commented on code in PR #17787: URL: https://github.com/apache/pinot/pull/17787#discussion_r2866865963
########## pinot-common/src/main/java/org/apache/pinot/common/utils/KeepPipelineBreakerStatsPredicate.java: ########## @@ -16,7 +16,7 @@ * specific language governing permissions and limitations * under the License. */ -package org.apache.pinot.server.starter.helix; +package org.apache.pinot.common.utils; Review Comment: Any reason moving this class? Seems like a server specific config handler. If we want to apply it to other components, move it to `pinot-query-runtime` given it is only related to MSE. Same for `SendStatsPredicate` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
