Jackie-Jiang commented on code in PR #17308:
URL: https://github.com/apache/pinot/pull/17308#discussion_r2785309192
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/ExpressionTransformer.java:
##########
@@ -54,24 +55,40 @@ public class ExpressionTransformer implements
RecordTransformer {
final LinkedHashMap<String, FunctionEvaluator> _expressionEvaluators = new
LinkedHashMap<>();
private final boolean _continueOnError;
private final ThrottledLogger _throttledLogger;
+ /**
+ * When true, transforms run even if the column already has a non-null
value. This is used for post-upsert transforms
+ * where derived columns should be recomputed on the merged row.
+ */
+ private final boolean _overwriteExistingValues;
public ExpressionTransformer(TableConfig tableConfig, Schema schema) {
+ this(tableConfig, schema, null, true, false);
+ }
+
+ public ExpressionTransformer(TableConfig tableConfig, Schema schema,
Review Comment:
This is not addressed. It is very confusing to have both table config and
`transformConfigs`
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/ExpressionTransformer.java:
##########
@@ -46,15 +53,89 @@ public class ExpressionTransformer implements
RecordTransformer {
private static final Logger LOGGER =
LoggerFactory.getLogger(ExpressionTransformer.class);
@VisibleForTesting
- final LinkedHashMap<String, FunctionEvaluator> _expressionEvaluators;
+ final LinkedHashMap<String, FunctionEvaluator> _expressionEvaluators = new
LinkedHashMap<>();
+ private final Set<String> _implicitMapTransformColumns = new HashSet<>();
Review Comment:
What is this map for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
