Jackie-Jiang commented on code in PR #16789: URL: https://github.com/apache/pinot/pull/16789#discussion_r2364899206
########## pinot-core/src/main/java/org/apache/pinot/core/operator/SegmentBlockOperator.java: ########## @@ -0,0 +1,42 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.operator; + +import org.apache.pinot.core.common.Block; +import org.apache.pinot.core.common.Operator; + + +/// An operator that is bound to a specific segment. Review Comment: > The problem with that is that some operators may be at the same time descending and ascending I don't follow this. When an operator implements this interface, it must iterate the docs in either normal order or reverse order. Other operators shouldn't implement this interface. When an operator implementing this interface is created, the order should already be fixed. The reason why I don't like `Did` is that there are 2 very commonly used `Did` - `DictId` and `DocId`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
