Jackie-Jiang commented on code in PR #16432: URL: https://github.com/apache/pinot/pull/16432#discussion_r2356779894
########## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerConfig.java: ########## @@ -119,6 +119,9 @@ public class HelixInstanceDataManagerConfig implements InstanceDataManagerConfig private static final int DEFAULT_DELETED_TABLES_CACHE_TTL_MINUTES = 60; private static final int DEFAULT_DELETED_SEGMENTS_CACHE_SIZE = 10_000; private static final int DEFAULT_DELETED_SEGMENTS_CACHE_TTL_MINUTES = 2; + // By default, check CRC matching when loading segments. + private static final boolean DEFAULT_CHECK_CRC_ON_SEGMENT_LOAD = true; + private static final String CHECK_CRC_ON_SEGMENT_LOAD = "check.crc.on.segment.load"; Review Comment: Sorry for the late reply. Ideally we want to keep the default `false`, can we rename the config to `skip.crc.check.on.segment.load`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
