Copilot commented on code in PR #16755:
URL: https://github.com/apache/pinot/pull/16755#discussion_r2325002781
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/CombinedFilterOperator.java:
##########
@@ -61,8 +61,16 @@ public String toExplainString() {
@Override
protected BlockDocIdSet getTrues() {
Tracing.activeRecording().setNumChildren(2);
- BlockDocIdSet mainFilterDocIdSet =
_mainFilterOperator.nextBlock().getNonScanFilterBLockDocIdSet();
+ BlockDocIdSet mainFilterDocIdSet =
_mainFilterOperator.nextBlock().getNonScanFilterBlockDocIdSet();
Review Comment:
Method name has a typo: 'BLockDocIdSet' should be 'BlockDocIdSet'.
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/MVScanDocIdIterator.java:
##########
@@ -258,4 +243,44 @@ public void close() {
_readerContext.close();
}
}
+
+ public static class Asc extends MVScanDocIdIterator {
+ public Asc(PredicateEvaluator predicateEvaluator, DataSource dataSource,
int numDocs) {
+ super(predicateEvaluator, dataSource, numDocs);
+ }
+
+ @Override
+ public int next() {
+ while (_nextDocId < _numDocs) {
+ int nextDocId = _nextDocId++;
+ // TODO: The performance can be improved by batching the docID lookups
similar to how it's done in
+ // SVScanDocIdIterator
+ boolean doesValueMatch = _valueMatcher.doesValueMatch(nextDocId);
+ if (doesValueMatch) {
+ return nextDocId;
+ }
+ }
+ close();
+ return Constants.EOF;
+ }
+ }
+
Review Comment:
The `Desc` class constructor is missing its class declaration. The code
shows a constructor body without the proper class definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
