Copilot commented on code in PR #16764:
URL: https://github.com/apache/pinot/pull/16764#discussion_r2325204928
##########
pinot-perf/src/main/java/org/apache/pinot/perf/BenchmarkOrderByQueries.java:
##########
@@ -115,14 +115,16 @@ public static void main(String[] args)
.addSingleValueDimension(LOW_CARDINALITY_STRING_COL,
FieldSpec.DataType.STRING)
.build();
+ @Param({"true", "false"})
+ private boolean _zasc; // called zasc just to force this parameter to be the
last used in the report
@Param("1500000")
private int _numRows;
- @Param({"naive", "null"})
- private String _orderByAlgorithm;
- @Param({"EXP(0.5)"})
- String _scenario;
+ //@Param({"EXP(0.5)"})
+ String _scenario = "EXP(0.5)";
Review Comment:
The commented-out `@Param` annotation should be removed entirely. If the
scenario is now constant, consider making it a `private static final` constant
instead of a mutable field.
```suggestion
private static final String SCENARIO = "EXP(0.5)";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
