noob-se7en commented on issue #16317: URL: https://github.com/apache/pinot/issues/16317#issuecomment-3241400691
@Jackie-Jiang From this PR: https://github.com/apache/pinot/pull/16519 > The long term fix should be to allow user to specify the data type for the input column if they are not defined in the schema For the supported aggregations types: MAX,MIN,SUM,COUNT,SUMPRECISION I don't see input data other then Number or String and the current code already handles it. For the DISTINCTCOUNTHLL, DISTINCTCOUNTHLLPLUS I see they can work with any input data using based on: https://github.com/apache/pinot/blob/ed5e306c0fd006c0d52e993d4f7c5cb2b11dcab9/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/aggregator/DistinctCountHLLValueAggregator.java#L80-L91 So do we really need long term solution where we have new config for input data type: ``` "aggregationConfigs": [ { "columnName": "total_sales", "aggregationFunction": "SUM(price)", "inputDataType": "STRING", }, ] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
