noob-se7en opened a new pull request, #16740: URL: https://github.com/apache/pinot/pull/16740
Post this PR: https://github.com/apache/pinot/pull/16657 and this PR: https://github.com/apache/pinot/pull/15190 recentlyOffloadedConsumingSegments cache is not required. This cache was added with reason: ``` // NOTE: Helix might process CONSUMING -> DROPPED transition as 2 separate transitions: CONSUMING -> OFFLINE followed // by OFFLINE -> DROPPED. Use this cache to track the segments that just went through CONSUMING -> OFFLINE transition // to detect CONSUMING -> DROPPED transition. // TODO: Check how Helix handle CONSUMING -> DROPPED transition and remove this cache if it's not needed. ``` This cache was used to detect when `CONSUMING -> OFFLINE` was followed by `OFFLINE -> DROPPED`. And when it's detected, the ingestion metrics are removed. However after this PR: https://github.com/apache/pinot/pull/16657, the ingestion metrics are removed in `CONSUMING -> OFFLINE` transition itself (`onConsumingToDropped(tableNameWithType, segmentName)` is similar to `onConsumingToOffline(realtimeTableName, segmentName)`). Also now we have direct transition from CONSUMING -> DROPPED after this PR: https://github.com/apache/pinot/pull/15190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
