vvivekiyer commented on code in PR #16340:
URL: https://github.com/apache/pinot/pull/16340#discussion_r2306205436
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java:
##########
@@ -672,9 +673,12 @@ public void start()
_serverConf.getProperty(Server.CONFIG_OF_ENABLE_THREAD_ALLOCATED_BYTES_MEASUREMENT,
Server.DEFAULT_THREAD_ALLOCATED_BYTES_MEASUREMENT));
// Initialize the thread accountant for query killing
+ PinotConfiguration threadAccountantConfigs =
_serverConf.subset(CommonConstants.PINOT_QUERY_SCHEDULER_PREFIX);
+ // This allows for custom implementations of WorkloadBudgetManager.
+ WorkloadBudgetManager workloadBudgetManager =
createWorkloadBudgetManager(threadAccountantConfigs);
_resourceUsageAccountant =
Tracing.ThreadAccountantOps.createThreadAccountant(
_serverConf.subset(CommonConstants.PINOT_QUERY_SCHEDULER_PREFIX),
_instanceId,
- org.apache.pinot.spi.config.instance.InstanceType.SERVER);
+ org.apache.pinot.spi.config.instance.InstanceType.SERVER,
workloadBudgetManager);
Review Comment:
Cool. We can make this change later when we deem necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
